Add verify parameter to control TLS certificate verification #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
cjeanner
force-pushed
the
add-tls-verify-parameter
branch
from
996e4fe to
ff1ec9b
Compare
Add a new 'verify' parameter to QuadsApi and QuadsBase constructors to allow users to control TLS certificate verification behavior. The parameter accepts: - False (default): Disable certificate verification (backward compatible) - True: Enable verification using system's default CA bundle - str: Path to a custom CA bundle file This change updates both the _make_request method and the login method to use the verify parameter instead of hardcoded verify=False. Changes: - Add verify parameter to QuadsBase.__init__ with Union[bool, str] type - Update _make_request to use self.verify - Update login method to use self.verify - Add comprehensive docstring explaining the parameter - Add 6 new tests covering all verify parameter scenarios - Update usage documentation with examples Code generated with assistance from Auto (Cursor AI agent router). All tests pass and maintain backward compatibility.
cjeanner
force-pushed
the
add-tls-verify-parameter
branch
from
ff1ec9b to
a984855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new 'verify' parameter to QuadsApi and QuadsBase constructors to allow users to control TLS certificate verification behavior.
The parameter accepts:
This change updates both the _make_request method and the login method to use the verify parameter instead of hardcoded verify=False.
Changes:
Code generated with assistance from Auto (Cursor AI agent router). All tests pass and maintain backward compatibility.